a11y(dialogs): full keyboard operability - #780
Merged
mikewheeleer merged 1 commit intoJul 26, 2026
Merged
Conversation
- Fix ConfirmDialog cancel button: add focus-visible ring (was unstyled) - Fix ConfirmDialog confirm button: tone-aware ring (blue default / red destructive) replacing the broken primary-600 token - Enable restoreFocus in useDialogFocusTrap so trigger regains focus after dialog closes (WCAG 2.1 SC 3.2.2) - Add ConfirmDialogKeyboard.test.tsx with 21 tests covering: tab order, wrap forward/backward, Enter/Space activation, Escape from any position, focus restoration, focus-visible classes, and destructive tone keyboard flow
|
@unajiogenyi05-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
CodeMasked
pushed a commit
to CodeMasked/Talenttrust-Frontend
that referenced
this pull request
Jul 28, 2026
…llback (Talenttrust#780) Replace console.error with structured logging through the application logger in SWRCache background revalidation. Add an optional onRevalidationError callback hook so consumers can increment metrics or trigger alerts. The cache continues to swallow-and-serve-stale as before; callers never see background errors. - Route errors through logger.error() with cacheKey and serialised error - Add OnRevalidationError callback type and SWRCacheOptions.onRevalidationError - Wrap callback invocation in try/catch so throwing callbacks cannot crash - Comprehensive tests: structured log output, callback firing, callback omission, throwing callback, concurrent coalescing, activeFetches bookkeeping, and timer leak detection Closes Talenttrust#621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #
Type of Change
Pre-flight Checklist
All items must be checked before requesting review.
npm run lintpasses with no errorsnpm testpasses with no failuresnpm run buildcompletes successfullyTesting & Coverage
(run
npm test -- --coverageand check the per-file table)the shared utilities in
src/test-utils/a11y.tsxWhat was tested?
Accessibility & Security Notes
Accessibility
Security
closes #638